Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1273373003: Don't analyze some tests that depend on bleeding edge SDK support (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't analyze some tests that depend on bleeding edge SDK support BUG= Committed: https://code.google.com/p/dart/source/detail?r=2306fd2fccc2af0ca204511f1d282155d21f6f2e

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
A runtime/observatory/.analysis_options View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-10 17:43:35 UTC) #2
turnidge
lgtm
5 years, 4 months ago (2015-08-10 17:44:04 UTC) #3
Cutch
5 years, 4 months ago (2015-08-10 17:44:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2306fd2fccc2af0ca204511f1d282155d21f6f2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698