Issue 12732004: Add a bunch of ugly debugging prints to figure out why the bots are failing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12732004: Add a bunch of ugly debugging prints to figure out why the bots are failing. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a bunch of ugly debugging prints to figure out why the bots are failing. Committed: https://code.google.com/p/dart/source/detail?r=19751

Patch Set 1 #

Patch Set 2 : merge #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -27 lines)			Patch
M	pkg/scheduled_test/lib/scheduled_process.dart	View		3 chunks	+18 lines, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/schedule.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/scheduled_process_test.dart	View	1	3 chunks	+27 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #2 manually as r19751 (presubmit successful).

7 years, 9 months ago (2013-03-08 23:52:18 UTC) #2

Jennifer Messerly

ugly but seems necessarily. LGTM I wonder, would it be crazy to turn them into ...

7 years, 9 months ago (2013-03-09 00:05:57 UTC) #3

nweiz

7 years, 9 months ago (2013-03-09 00:42:21 UTC) #4

Message was sent while issue was closed.

On 2013/03/09 00:05:57, John Messerly wrote:
> ugly but seems necessarily. LGTM
> 
> I wonder, would it be crazy to turn them into log messages (perhaps at a very
> low level), so you could more easily flip them on or off when tests flake? Or
is
> this more of a one-off bug?

This is a one-off sort of thing. If we ever get a unified logging framework, it
would be nice to integrate with that, but it seems like a long way away.

Expand Messages | Collapse Messages