Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 127313002: dart2js typed data constructor argument validation (Closed)

Created:
6 years, 11 months ago by sra1
Modified:
6 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, srdjan
Visibility:
Public.

Description

dart2js typed data constructor argument validation Addresses Issue 15951. Also change parameter names to match documentation. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31615

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -50 lines) Patch
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 21 chunks +97 lines, -50 lines 0 comments Download
A tests/lib/typed_data/constructor_checks_test.dart View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
6 years, 11 months ago (2014-01-08 01:20:21 UTC) #1
Cutch
lgtm
6 years, 11 months ago (2014-01-08 17:23:14 UTC) #2
sra1
6 years, 11 months ago (2014-01-08 17:30:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698