Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273033007: Fix ??= AST modification (Closed)

Created:
5 years, 4 months ago by hausner
Modified:
5 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M runtime/vm/parser.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 6 chunks +12 lines, -8 lines 0 comments Download
M tests/language/nullaware_opt_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 4 months ago (2015-08-11 17:53:27 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1273033007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1273033007/diff/1/runtime/vm/parser.cc#newcode8647 runtime/vm/parser.cc:8647: false, Add comment /*is_compound */ https://codereview.chromium.org/1273033007/diff/1/runtime/vm/parser.cc#newcode8866 runtime/vm/parser.cc:8866: false, ...
5 years, 4 months ago (2015-08-11 19:26:10 UTC) #3
hausner
As discussed offline, made is_compound parameter optional. Thanks
5 years, 4 months ago (2015-08-11 19:47:21 UTC) #4
hausner
5 years, 4 months ago (2015-08-11 20:14:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fc55f38aaf053a62d1959b09644ecff49fc35d43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698