Issue 1273003005: Keep only unique overridden elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1273003005: Keep only unique overridden elements. (Closed)

Created:
5 years, 4 months ago by scheglov

Modified:
5 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Keep only unique overridden elements. If the implemented interfaces don't declare an element, keep only a single copy of the element - from the superclass. In Dart Editor we use any element, but in in IDEA we show all of them, and we don't want to have duplicates. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/089f84f6cd79490f55b85e5ca18c7114c6dfcd54

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -3 lines)			Patch
	M	pkg/analysis_server/lib/src/computer/computer_overrides.dart	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
	M	pkg/analysis_server/test/analysis/notification_overrides_test.dart	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 4 months ago (2015-08-10 23:13:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
089f84f6cd79490f55b85e5ca18c7114c6dfcd54 (presubmit successful).