Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1272963004: Add error and message to tools/make_links.py for duplicate packages. (Closed)

Created:
5 years, 4 months ago by Bill Hesse
Modified:
5 years, 4 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add error and message to tools/make_links.py for duplicate packages. BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/84d208a21f6454a2f22bf6f98a607705dce9e20d

Patch Set 1 #

Patch Set 2 : remove debug printing #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/make_links.py View 1 2 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
5 years, 4 months ago (2015-08-10 08:15:55 UTC) #2
ricow1
lgtm https://codereview.chromium.org/1272963004/diff/20001/tools/make_links.py File tools/make_links.py (right): https://codereview.chromium.org/1272963004/diff/20001/tools/make_links.py#newcode31 tools/make_links.py:31: old_directories = {'package_config': add a note on what ...
5 years, 4 months ago (2015-08-10 10:19:31 UTC) #3
Bill Hesse
Committed patchset #3 (id:40001) manually as 84d208a21f6454a2f22bf6f98a607705dce9e20d (presubmit successful).
5 years, 4 months ago (2015-08-10 12:35:56 UTC) #4
Bill Hesse
5 years, 4 months ago (2015-08-10 12:36:18 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1272963004/diff/20001/tools/make_links.py
File tools/make_links.py (right):

https://codereview.chromium.org/1272963004/diff/20001/tools/make_links.py#new...
tools/make_links.py:31: old_directories = {'package_config':
On 2015/08/10 10:19:30, ricow1 wrote:
> add a note on what this is

Done.

https://codereview.chromium.org/1272963004/diff/20001/tools/make_links.py#new...
tools/make_links.py:104: if name in linked_names:
On 2015/08/10 10:19:30, ricow1 wrote:
> Add a comment stating what the issues is, something likeÆ
> # We have an issue with leftover entries from the DEPS file if we 
> # move the package from third_party/pkg to third_party/pkg_tested
> # (or the other way around).

Done.

Powered by Google App Engine
This is Rietveld 408576698