Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1272833003: Revert "Run "pub run" against the .packages file." (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Run "pub run" against the .packages file." This reverts commit dc626af36a4b31898cdde90b2fca99ad65639fab. This broke due to dart-lang/sdk#23991. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/7fbc104018cdac3d50067392754101526f78dde6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M lib/src/entrypoint.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/src/executable.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-05 22:50:01 UTC) #1
Bob Nystrom
lgtm :(
5 years, 4 months ago (2015-08-05 23:16:04 UTC) #2
nweiz
5 years, 4 months ago (2015-08-05 23:18:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fbc104018cdac3d50067392754101526f78dde6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698