Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1272813003: Support "--checked" in pub run and global run. (Closed)

Created:
5 years, 4 months ago by Bob Nystrom
Modified:
5 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, sethladd
Base URL:
https://github.com/dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support "--checked" in pub run and global run. Fixes #1230. R=nweiz@google.com Committed: https://github.com/dart-lang/pub/commit/1682e0bd5e984a5f88029c6e5ea625c099072323

Patch Set 1 #

Total comments: 4

Patch Set 2 : Revise. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -47 lines) Patch
M lib/src/command/global_run.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/command/run.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M lib/src/executable.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download
M lib/src/global_packages.dart View 3 chunks +5 lines, -4 lines 0 comments Download
A + test/global/run/runs_script_in_checked_mode_test.dart View 1 chunk +7 lines, -14 lines 0 comments Download
A + test/global/run/runs_script_in_unchecked_mode_test.dart View 2 chunks +12 lines, -3 lines 0 comments Download
M test/run/runs_the_script_in_checked_mode_test.dart View 1 chunk +3 lines, -9 lines 0 comments Download
A + test/run/runs_the_script_in_unchecked_mode_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
5 years, 4 months ago (2015-08-05 23:45:28 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1272813003/diff/1/lib/src/command/global_run.dart File lib/src/command/global_run.dart (right): https://codereview.chromium.org/1272813003/diff/1/lib/src/command/global_run.dart#newcode29 lib/src/command/global_run.dart:29: argParser.addFlag("checked", abbr: "c", negatable: false, Why not make ...
5 years, 4 months ago (2015-08-06 00:08:28 UTC) #3
Bob Nystrom
Committed patchset #2 (id:20001) manually as 1682e0bd5e984a5f88029c6e5ea625c099072323 (presubmit successful).
5 years, 4 months ago (2015-08-06 00:12:41 UTC) #4
Bob Nystrom
5 years, 4 months ago (2015-08-06 16:54:42 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1272813003/diff/1/lib/src/command/global_run....
File lib/src/command/global_run.dart (right):

https://codereview.chromium.org/1272813003/diff/1/lib/src/command/global_run....
lib/src/command/global_run.dart:29: argParser.addFlag("checked", abbr: "c",
negatable: false,
On 2015/08/06 00:08:28, nweiz wrote:
> Why not make this negatable? The VM supports --no-checked.

TIL. Done.

https://codereview.chromium.org/1272813003/diff/1/lib/src/executable.dart
File lib/src/executable.dart (right):

https://codereview.chromium.org/1272813003/diff/1/lib/src/executable.dart#new...
lib/src/executable.dart:271: List<String> args, {bool checked}) {
On 2015/08/06 00:08:28, nweiz wrote:
> ": false"

Done.

Powered by Google App Engine
This is Rietveld 408576698