Improve documentation for Pattern.allMatches.

Improve documentation for Pattern.allMatches.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/0370922ca4d3326ce23af2ba884836483f67e564

[floitsch, 2015-08-11 09:41:32]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-08-11 10:15:39]

lgtm

https://codereview.chromium.org/1272743004/diff/1/sdk/lib/core/pattern.dart
File sdk/lib/core/pattern.dart (right):

https://codereview.chromium.org/1272743004/diff/1/sdk/lib/core/pattern.dart#n...
sdk/lib/core/pattern.dart:23: * match, this function should not compute all
possible matches.
Drop the "if possible" - just require it. It's an oversight that it doesn't say
so, and I don't think there are any implementations that does it wrong (there
aren't that many pattern implementations at all).

The returned iterable lazily computes ...

[floitsch, 2015-08-11 11:25:25]

https://codereview.chromium.org/1272743004/diff/1/sdk/lib/core/pattern.dart
File sdk/lib/core/pattern.dart (right):

https://codereview.chromium.org/1272743004/diff/1/sdk/lib/core/pattern.dart#n...
sdk/lib/core/pattern.dart:23: * match, this function should not compute all
possible matches.
On 2015/08/11 10:15:39, Lasse Reichstein Nielsen wrote:
> Drop the "if possible" - just require it. It's an oversight that it doesn't
say
> so, and I don't think there are any implementations that does it wrong (there
> aren't that many pattern implementations at all).
> 
> The returned iterable lazily computes ...

Unfortunately the String.allMatches does it wrong (both on dart2js and the VM).
I will try to fix them.
Done.

[floitsch, 2015-08-11 11:26:12]

Committed patchset #3 (id:20002) manually as
0370922ca4d3326ce23af2ba884836483f67e564 (presubmit successful).