Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1272613003: dart2js: use correct Compiler class. (Closed)

Created:
5 years, 4 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/headers.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
TBR.
5 years, 4 months ago (2015-08-05 12:24:33 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 6377f1858726949354437381f596d82316c361dd (presubmit successful).
5 years, 4 months ago (2015-08-05 12:24:41 UTC) #3
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-05 15:48:08 UTC) #4
Message was sent while issue was closed.
lgtm

definitely something I've been wanting to refactor, it's confusing to have two
Compiler classes :)

Powered by Google App Engine
This is Rietveld 408576698