Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 12723012: Attempting to fix indexed_db IE10 test timeouts. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

On the test machines, this test is sometimes taking upwards of 2 minutes, but on a local IE10 machine it's closer to 300ms (faster than Chrome). In addition, the indexed_db tests have fairly wide variance- from 6s to 2mins. My guess is that since all of the tests are using the same DB name, that there's a conflict where one test has the DB open and another test is blocked trying to delete it. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20284

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/html/indexeddb_1_test.dart View 4 chunks +16 lines, -4 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_4_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-20 16:53:29 UTC) #1
sra1
lgtm
7 years, 9 months ago (2013-03-20 19:11:16 UTC) #2
blois
7 years, 9 months ago (2013-03-20 19:38:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698