Issue 12719002: Update context2d.arc to take optional anticlockwise parameter

Issue 12719002: Update context2d.arc to take optional anticlockwise parameter (Closed)

Created:
7 years, 9 months ago by Andrei Mouravski

Modified:
7 years, 8 months ago

Reviewers:
sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Update context2d.arc to take optional anticlockwise parameter"" Fixed checked mode test failures. Committed: https://code.google.com/p/dart/source/detail?r=19747

Patch Set 5 : #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+244 lines, -98 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tests/html/canvasrenderingcontext2d_test.dart	View	1	2 chunks	+219 lines, -96 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	1 2 3 4	1 chunk	+7 lines, -0 lines	2 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

blois

On 2013/03/08 20:17:05, Andrei Mouravski wrote: > PTAL. These changes look good, but there's still ...

7 years, 9 months ago (2013-03-08 21:00:17 UTC) #4

Andrei Mouravski

Committed patchset #5 manually as r19747 (presubmit successful).

7 years, 9 months ago (2013-03-08 23:33:46 UTC) #7

sra1

https://chromiumcodereview.appspot.com/12719002/diff/15003/tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate (right): https://chromiumcodereview.appspot.com/12719002/diff/15003/tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate#newcode47 tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:47: void arc(num x, num y, num radius, num startAngle, ...

7 years, 8 months ago (2013-04-09 22:30:58 UTC) #8

Andrei Mouravski

7 years, 8 months ago (2013-04-09 23:33:24 UTC) #9

Message was sent while issue was closed.

Can you explain more?

https://chromiumcodereview.appspot.com/12719002/diff/15003/tools/dom/template...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://chromiumcodereview.appspot.com/12719002/diff/15003/tools/dom/template...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:47:
void arc(num x,  num y,  num radius,  num startAngle, num endAngle,
On 2013/04/09 22:30:58, sra1 wrote:
> This won't inline very well for dart2js.
> Is it possible to make arc the native method?
> The 6th argument is optional in webkit and w3 IDL.
> 
> Is there some browser that either does the wrong thing?
> If the problem is Dartium, we can use $if DART2JS

The argument is optional in the spec, too:
http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/#dom-context-2d-arc

Expand Messages | Collapse Messages