Issue 1271773003: Allow threads to exit an isolate during rendezvous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1271773003: Allow threads to exit an isolate during rendezvous. (Closed)

Created:
5 years, 4 months ago by koda

Modified:
5 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Allow threads to exit an isolate during rendezvous. The state is saved and will be visited, so this is safe. Also clarify that nested calls to SafepointThreads from the same thread is not supported, and check for this. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/0897409f599d17dd63fa5f69a1063051602f5f23

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	runtime/vm/thread_registry.h	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
	M	runtime/vm/thread_registry.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 4 months ago (2015-08-04 16:30:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0897409f599d17dd63fa5f69a1063051602f5f23 (presubmit successful).