fix completion replacement offset/length for invalid token in switch statement

fix completion replacement offset/length for invalid token in switch statement

Closes #23947

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/e8e6cf823ac1d282a4da8342015d1e691bcf978e

[danrubel, 2015-08-03 06:08:53]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-03 13:53:07]

LGTM

https://codereview.chromium.org/1271723002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/1271723002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:146:
if (token != null && request.offset < token.offset) {
Does this need to be a loop, or is the previous token guaranteed to contain the
request offset?

https://codereview.chromium.org/1271723002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:150:
if (request.offset == token.offset && !isKeywordOrIdentifier(token)) {
A comment about why this is necessary would be good. It isn't clear to me why we
want to back up to a token that doesn't contain the request offset.

[danrubel, 2015-08-03 21:00:12]

https://codereview.chromium.org/1271723002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/1271723002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:146:
if (token != null && request.offset < token.offset) {
On 2015/08/03 13:53:07, Brian Wilkerson wrote:
> Does this need to be a loop, or is the previous token guaranteed to contain
the
> request offset?

I considered that but did not have a test case that required a loop. Suggestion
welcome... which I will address in a subsequent CL.

https://codereview.chromium.org/1271723002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:150:
if (request.offset == token.offset && !isKeywordOrIdentifier(token)) {
On 2015/08/03 13:53:07, Brian Wilkerson wrote:
> A comment about why this is necessary would be good. It isn't clear to me why
we
> want to back up to a token that doesn't contain the request offset.

Good point. Added.

[danrubel, 2015-08-03 21:02:52]

Committed patchset #2 (id:20001) manually as
e8e6cf823ac1d282a4da8342015d1e691bcf978e (presubmit successful).