Issue 12716024: Handle deleting broken symlinks on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12716024: Handle deleting broken symlinks on Windows. (Closed)

Created:
7 years, 9 months ago by Bob Nystrom

Modified:
7 years, 9 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle deleting broken symlinks on Windows. BUG=https://code.google.com/p/dart/issues/detail?id=9192 Committed: https://code.google.com/p/dart/source/detail?r=20501

Patch Set 2 : Redo after syncing. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	utils/pub/entrypoint.dart	View	1	1 chunk	+9 lines, -3 lines	0 comments	Download
	M	utils/tests/pub/pub.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

https://codereview.chromium.org/12716024/diff/1/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://codereview.chromium.org/12716024/diff/1/utils/pub/entrypoint.dart#newcode303 utils/pub/entrypoint.dart:303: // first since deleteDir() does work on symlinks. Can ...

7 years, 9 months ago (2013-03-19 19:41:02 UTC) #2

Bob Nystrom

7 years, 9 months ago (2013-03-26 00:50:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20501 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12716024: Handle deleting broken symlinks on Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Redo after syncing. #

Messages