Issue 1271333003: Win64 doesn't support inline assembly. UNIMPLEMENTED for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1271333003: Win64 doesn't support inline assembly. UNIMPLEMENTED for now. (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Win64 doesn't support inline assembly. UNIMPLEMENTED for now. BUG= Committed: https://github.com/dart-lang/sdk/commit/f58dac21c1d5529d3873488ac91cd418e2534ec9

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/globals.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #2 (id:20001) manually as f58dac21c1d5529d3873488ac91cd418e2534ec9 (presubmit successful).

5 years, 4 months ago (2015-08-06 21:14:31 UTC) #1

regis

5 years, 4 months ago (2015-08-06 22:05:41 UTC) #4

Message was sent while issue was closed.

On 2015/08/06 21:15:02, Cutch wrote:
> mailto:TBR=regis@google.com

lgtm

If this was only used in Dart code, you could use a stub returning the frame
pointer of the caller. It's a bit trickier from C++ code, but it may be the only
solution.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages