Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1270953003: Fix test failure (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test failure patch from issue 1271693003 at patchset 20001 (http://crrev.com/1271693003#ps20001) Committed: https://github.com/dart-lang/sdk/commit/7640cf4b85f32df7f2181480711c9afc08a34418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M runtime/lib/developer.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 4 months ago (2015-08-04 14:05:23 UTC) #2
Cutch
On 2015/08/04 14:05:23, Cutch wrote: TBR
5 years, 4 months ago (2015-08-04 14:05:27 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as 7640cf4b85f32df7f2181480711c9afc08a34418 (presubmit successful).
5 years, 4 months ago (2015-08-04 14:05:38 UTC) #4
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-04 14:16:32 UTC) #6
Message was sent while issue was closed.
LGTM and thanks.

Powered by Google App Engine
This is Rietveld 408576698