Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1270603003: Bump the VM service protocol version to 2.0. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump the VM service protocol version to 2.0. This reflects the breaking changes since version 1.0, which was released in Dart 1.11. It also gets rid of the "draft" language in the VM service protocol documentation, since it will be (and has been) shipped in a stable Dart release. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/1b7c33a5b574ce4eb0d422b97363532b142fa880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M CHANGELOG.md View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nweiz
5 years, 4 months ago (2015-07-30 22:40:45 UTC) #2
Cutch
+turnidge
5 years, 4 months ago (2015-07-30 22:59:51 UTC) #4
turnidge
lgtm Please be sure the following tests pass committing: tools/test.py --arch=ia32 --mode=debug vm cc service
5 years, 4 months ago (2015-08-03 21:46:43 UTC) #5
nweiz
5 years, 4 months ago (2015-08-03 21:58:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b7c33a5b574ce4eb0d422b97363532b142fa880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698