Issue 12706014: Remove time dependent part of test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12706014: Remove time dependent part of test (Closed)

Created:
7 years, 9 months ago by ricow1

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove time dependent part of test This is flaking Committed: https://code.google.com/p/dart/source/detail?r=20158

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tests/lib/async/stream_periodic5_test.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/12706014/diff/1/tests/lib/async/stream_periodic5_test.dart File tests/lib/async/stream_periodic5_test.dart (right): https://codereview.chromium.org/12706014/diff/1/tests/lib/async/stream_periodic5_test.dart#newcode25 tests/lib/async/stream_periodic5_test.dart:25: subscription = stream.take(10).listen((i) { You could also make ...

7 years, 9 months ago (2013-03-18 11:45:17 UTC) #2

ricow1

7 years, 9 months ago (2013-03-18 13:56:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20158 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12706014: Remove time dependent part of test (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages