Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1270413002: Factor failing tests out of language/async_star_test.dart (Closed)

Created:
5 years, 4 months ago by Bill Hesse
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Factor failing tests out of language/async_star_test.dart Make async_star_test no longer a multitest, and stop using package:test in the factored tests. BUG=dartbug.com/2238, dartbug.com/22853 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/60c7a3d0abb5df3e833e15b279a0c0ff0fd39083

Patch Set 1 #

Patch Set 2 : File issues, fix status. #

Patch Set 3 : Add timeout on browsers. #

Total comments: 2

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -177 lines) Patch
A tests/language/async_star_await_pauses_test.dart View 1 1 chunk +34 lines, -0 lines 0 comments Download
A tests/language/async_star_cancel_while_paused_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A + tests/language/async_star_regression_2238_test.dart View 1 1 chunk +11 lines, -13 lines 0 comments Download
A tests/language/async_star_regression_fisk_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A + tests/language/async_star_stream_take_test.dart View 1 2 3 1 chunk +13 lines, -16 lines 0 comments Download
A tests/language/async_star_take_reyield_test.dart View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M tests/language/async_star_test.dart View 7 chunks +0 lines, -137 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
Here is a first stab at factoring out failing tests. I haven't run them yet ...
5 years, 4 months ago (2015-08-05 14:37:19 UTC) #2
Bill Hesse
Ready for review - tested on vm, dart2js, and analyzer.
5 years, 4 months ago (2015-08-06 09:41:59 UTC) #3
Lasse Reichstein Nielsen
LGTM https://codereview.chromium.org/1270413002/diff/40001/tests/language/async_star_await_pauses_test.dart File tests/language/async_star_await_pauses_test.dart (right): https://codereview.chromium.org/1270413002/diff/40001/tests/language/async_star_await_pauses_test.dart#newcode24 tests/language/async_star_await_pauses_test.dart:24: r += await new Future.delayed(new Duration(milliseconds: 10), () ...
5 years, 4 months ago (2015-08-06 12:38:42 UTC) #4
Bill Hesse
5 years, 4 months ago (2015-08-06 12:56:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
60c7a3d0abb5df3e833e15b279a0c0ff0fd39083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698