Issue 12703041: Fix status file to skip basic_debugger_test as it is still failing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12703041: Fix status file to skip basic_debugger_test as it is still failing. (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
srdjan, kustermann

CC:
reviews_dartlang.org, kustermann

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix status file to skip basic_debugger_test as it is still failing. Committed: https://code.google.com/p/dart/source/detail?r=20536

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tests/standalone/standalone.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

Committed patchset #1 manually as r20536 (presubmit successful).

7 years, 9 months ago (2013-03-26 19:57:11 UTC) #3

kustermann

7 years, 9 months ago (2013-03-26 21:18:56 UTC) #4

Message was sent while issue was closed.

Does not look good to me :-(

Why do you skip it on all platforms?
Why do you not mark it as flaky (so the bot is green, but we can at least see
what's going on in the flaky log)?

AFAIK only mac-debug and linux-debug failed after my CL. The mac one had
probably one left-over process (which can be fixed by rebooting the machine) and
the linux one hit probably the race condition (see my comment on the bug).

My main concern is that we have now ZERO test coverage of the debugger.

Expand Messages | Collapse Messages