Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270103002: Allow Dart code to register service protocol handlers (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow Dart code to register service protocol handlers - Add 'registerExtension' to dart:developer - A service protocol handler must implement ServiceExtensionHandler - Service extensions can report result OR error code / message R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/0f13b9c9319a11fd537b50a83f2c40f4ae6104ea

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -3 lines) Patch
A runtime/observatory/tests/service/developer_extension_test.dart View 1 2 3 4 1 chunk +115 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/service.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 2 chunks +50 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/developer/extension.dart View 1 2 3 4 1 chunk +182 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Cutch
5 years, 4 months ago (2015-08-04 13:50:31 UTC) #2
turnidge
https://codereview.chromium.org/1270103002/diff/20001/sdk/lib/developer/extension.dart File sdk/lib/developer/extension.dart (right): https://codereview.chromium.org/1270103002/diff/20001/sdk/lib/developer/extension.dart#newcode46 sdk/lib/developer/extension.dart:46: bool _invokeExtension(String method, As discussed offline, let's make this ...
5 years, 4 months ago (2015-08-04 18:21:27 UTC) #3
Cutch
On 2015/08/04 18:21:27, turnidge wrote: > https://codereview.chromium.org/1270103002/diff/20001/sdk/lib/developer/extension.dart > File sdk/lib/developer/extension.dart (right): > > https://codereview.chromium.org/1270103002/diff/20001/sdk/lib/developer/extension.dart#newcode46 > ...
5 years, 4 months ago (2015-08-05 00:00:54 UTC) #4
turnidge
lgtm w/ 2 comments https://codereview.chromium.org/1270103002/diff/60001/runtime/observatory/tests/service/developer_extension_test.dart File runtime/observatory/tests/service/developer_extension_test.dart (right): https://codereview.chromium.org/1270103002/diff/60001/runtime/observatory/tests/service/developer_extension_test.dart#newcode16 runtime/observatory/tests/service/developer_extension_test.dart:16: Map paremeters) { Reminder to ...
5 years, 4 months ago (2015-08-06 18:12:54 UTC) #5
Cutch
https://codereview.chromium.org/1270103002/diff/60001/runtime/observatory/tests/service/developer_extension_test.dart File runtime/observatory/tests/service/developer_extension_test.dart (right): https://codereview.chromium.org/1270103002/diff/60001/runtime/observatory/tests/service/developer_extension_test.dart#newcode16 runtime/observatory/tests/service/developer_extension_test.dart:16: Map paremeters) { On 2015/08/06 18:12:54, turnidge wrote: > ...
5 years, 4 months ago (2015-08-06 23:20:18 UTC) #6
Cutch
5 years, 4 months ago (2015-08-06 23:21:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
0f13b9c9319a11fd537b50a83f2c40f4ae6104ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698