Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270033002: Stop unnecessary Observatory rebuilds (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop unnecessary Observatory rebuilds *) Turns out that gyp generates broken Makefiles when a target has more than one output. Avoid this bug by changing Observatory targets to have one output. *) NOTE: generate_snapshot_bin still has two outputs and will always rebuild because of this. *) Some misc. cleanups to observatory.gypi (removing redundant dependencies / inputs). R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/fbb32461d8654ed10fd4b25956700ae022190b05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M runtime/observatory/observatory.gypi View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-03 14:23:09 UTC) #2
zra
LGTM Thanks for looking into this!
5 years, 4 months ago (2015-08-03 15:39:01 UTC) #3
Cutch
5 years, 4 months ago (2015-08-03 17:04:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fbb32461d8654ed10fd4b25956700ae022190b05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698