Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1269783004: Fix constructor closures in checked mode (Closed)

Created:
5 years, 4 months ago by hausner
Modified:
5 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix constructor closures in checked mode The parameters of constructor closures must be dynamic. The Spec says so, and it’s necessary. The formal type of constructor parameters may not be valid in the context of the closure function, e.g. if it is a type parameter. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/90adbb2968d62e25610649e8baa1560847a10389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M runtime/vm/parser.cc View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 4 months ago (2015-08-04 17:36:51 UTC) #2
regis
LGTM
5 years, 4 months ago (2015-08-04 18:56:52 UTC) #3
hausner
5 years, 4 months ago (2015-08-04 19:36:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90adbb2968d62e25610649e8baa1560847a10389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698