Issue 1269643002: - Fix logic bug when skipping comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1269643002: - Fix logic bug when skipping comments. (Closed)

Created:
5 years, 4 months ago by Ivan Posva

Modified:
5 years, 4 months ago

Reviewers:
koda, siva

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	runtime/bin/vmservice/loader.dart	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Ivan Posva

Committed patchset #1 (id:1) manually as a78db046a683d9cefa1dc950f16d8a255ac87c95 (presubmit successful).

5 years, 4 months ago (2015-07-29 22:39:55 UTC) #3

koda

5 years, 4 months ago (2015-07-29 22:51:14 UTC) #5

Message was sent while issue was closed.

DBC

Would it be easy enough to add a unit test to prevent the same bug from
reappearing if/when someone refactors the code?