Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 126963002: Create a compiler_unsupported package in pkg. (Closed)

Created:
6 years, 11 months ago by devoncarew
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Create a compiler_unsupported package in pkg. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31896

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
A pkg/compiler_unsupported/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler_unsupported/LICENSE View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/compiler_unsupported/README.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/compiler_unsupported/pubspec.yaml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/compiler_unsupported/tool/create_library.py View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
devoncarew
This adds a pkg/compiler_unsupported directory to the repo and puts the basic package artifacts in ...
6 years, 11 months ago (2014-01-13 16:07:31 UTC) #1
floitsch
LGTM. I'm surprised you don't need the lib-directory, though.
6 years, 11 months ago (2014-01-14 19:37:11 UTC) #2
Jennifer Messerly
Historical note: we had code in tools/publish_pkg.py to publish compiler_unsupported, but it was dead code ...
6 years, 11 months ago (2014-01-14 23:44:47 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/126963002/diff/20001/pkg/compiler_unsupported/pubspec.yaml File pkg/compiler_unsupported/pubspec.yaml (right): https://codereview.chromium.org/126963002/diff/20001/pkg/compiler_unsupported/pubspec.yaml#newcode3 pkg/compiler_unsupported/pubspec.yaml:3: author: Dart Team <misc@dartlang.org> compiler-dev@dartlang.org ? https://codereview.chromium.org/126963002/diff/20001/pkg/compiler_unsupported/pubspec.yaml#newcode4 pkg/compiler_unsupported/pubspec.yaml:4: homepage: ...
6 years, 11 months ago (2014-01-14 23:46:52 UTC) #4
devoncarew
> I'm surprised you don't need the lib-directory, though As far as I know, the ...
6 years, 11 months ago (2014-01-15 00:05:39 UTC) #5
devoncarew
6 years, 11 months ago (2014-01-16 19:30:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r31896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698