Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1269553004: Fix incorrect expectation in allocations_test. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix incorrect expectation in allocations_test. The old code worked most of the time, since the Foo objects were usually not promoted to oldspace. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/40fc14d75aa8ab9d7bba3bda0ed07b3926fd8c03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/observatory/tests/service/allocations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 4 months ago (2015-07-31 21:27:32 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-07-31 21:32:28 UTC) #3
koda
5 years, 4 months ago (2015-07-31 21:34:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40fc14d75aa8ab9d7bba3bda0ed07b3926fd8c03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698