Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 12695014: Enable getUserMedia to take constraints for its parameters. (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable getUserMedia to take constraints for its parameters. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20245

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -20 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +22 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +21 lines, -5 lines 0 comments Download
M tests/html/interactive_test.dart View 4 chunks +34 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Navigator.darttemplate View 1 2 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
Fix for https://code.google.com/p/dart/issues/detail?id=8061
7 years, 9 months ago (2013-03-19 20:02:26 UTC) #1
blois
https://codereview.chromium.org/12695014/diff/1/tools/dom/templates/html/impl/impl_Navigator.darttemplate File tools/dom/templates/html/impl/impl_Navigator.darttemplate (right): https://codereview.chromium.org/12695014/diff/1/tools/dom/templates/html/impl/impl_Navigator.darttemplate#newcode29 tools/dom/templates/html/impl/impl_Navigator.darttemplate:29: * video: {'mandatory': It would be nice to move ...
7 years, 9 months ago (2013-03-19 20:35:23 UTC) #2
Emily Fortuna
ptal
7 years, 9 months ago (2013-03-19 20:49:19 UTC) #3
blois
lgtm
7 years, 9 months ago (2013-03-19 20:57:46 UTC) #4
Emily Fortuna
7 years, 9 months ago (2013-03-19 21:07:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698