Issue 12694002: Small dartdoc fixes.

Issue 12694002: Small dartdoc fixes. (Closed)

Created:
7 years, 9 months ago by Johnni Winther

Modified:
7 years, 8 months ago

Reviewers:
ahe, Andrei Mouravski

CC:
reviews_dartlang.org, Andrei Mouravski

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Small dartdoc fixes. Committed: https://code.google.com/p/dart/source/detail?r=21143

Patch Set 1 #

Total comments: 3

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View		2 chunks	+4 lines, -4 lines	2 comments	Download
	M	sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

On 2013/03/08 13:57:43, ahe wrote: > Can you test this? Not sure how. LGTM without ...

7 years, 8 months ago (2013-04-08 11:40:58 UTC) #4

Johnni Winther

https://codereview.chromium.org/12694002/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart (left): https://codereview.chromium.org/12694002/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart#oldcode219 sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:219: Uri libraryUri = cwd.resolve('${libraryRoot}/'); This is not an error, ...

7 years, 8 months ago (2013-04-08 13:06:23 UTC) #5

Andrei Mouravski

lgtm I say don't worry about testing the dartdoc bit, because that's something that's slowly ...

7 years, 8 months ago (2013-04-08 15:15:35 UTC) #6

ahe

LGTM https://codereview.chromium.org/12694002/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/12694002/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart#newcode219 sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:219: Uri libraryUri = cwd.resolve(appendSlash(libraryRoot.toString())); I think I prefer ...

7 years, 8 months ago (2013-04-09 08:31:31 UTC) #7

Johnni Winther

7 years, 8 months ago (2013-04-09 10:46:32 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 manually as r21143 (presubmit successful).

Expand Messages | Collapse Messages