Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1269393003: Run "pub run" against the .packages file. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run "pub run" against the .packages file. Previously this was using the packages/ directory, but that's no longer reliable since there's now an option to not generate it. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/dc626af36a4b31898cdde90b2fca99ad65639fab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/src/entrypoint.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/executable.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-05 21:27:00 UTC) #1
Bob Nystrom
LGTM!
5 years, 4 months ago (2015-08-05 21:30:27 UTC) #2
nweiz
5 years, 4 months ago (2015-08-05 21:35:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc626af36a4b31898cdde90b2fca99ad65639fab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698