Issue 1269393002: Fix ToStringVisitor to handle external functions (issue 23968)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1269393002: Fix ToStringVisitor to handle external functions (issue 23968) (Closed)

Created:
5 years, 4 months ago by Brian Wilkerson

Modified:
5 years, 4 months ago

Reviewers:
Bob Nystrom, scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1289 lines, -674 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	64 chunks	+1284 lines, -672 lines	0 comments	Download
M	pkg/analyzer/test/parse_compilation_unit_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Brian Wilkerson

Committed patchset #1 (id:1) manually as f05106f7d18c972b4cae5361830e2cbed5dddbac (presubmit successful).

5 years, 4 months ago (2015-08-05 15:27:56 UTC) #4

Message was sent while issue was closed.

LGTM!