Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1269143003: Adjust implementation of the hash-closurization to work with --no-lazy-dispatchers. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust implementation of the hash-closurization to work with --no-lazy-dispatchers. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/e8320e4081eef4ef4a23c66858e330d78e49df13

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -16 lines) Patch
M runtime/vm/code_generator.cc View 1 2 chunks +61 lines, -16 lines 0 comments Download
M runtime/vm/resolver.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-03 23:50:47 UTC) #2
hausner
LGTM with comment https://codereview.chromium.org/1269143003/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/1269143003/diff/1/runtime/vm/code_generator.cc#newcode1065 runtime/vm/code_generator.cc:1065: return; \ I'd leave the return ...
5 years, 4 months ago (2015-08-04 18:21:53 UTC) #3
rmacnak
https://codereview.chromium.org/1269143003/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/1269143003/diff/1/runtime/vm/code_generator.cc#newcode1065 runtime/vm/code_generator.cc:1065: return; \ On 2015/08/04 18:21:53, hausner wrote: > I'd ...
5 years, 4 months ago (2015-08-04 23:11:25 UTC) #4
rmacnak
5 years, 4 months ago (2015-08-04 23:12:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e8320e4081eef4ef4a23c66858e330d78e49df13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698