Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 12690004: Run type propagation after LICM to ensure correct reaching types for hoisted values. (Closed)

Created:
7 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run type propagation after LICM to ensure correct reaching types for hoisted values. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19954

Patch Set 1 #

Patch Set 2 : remove test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/language/deopt_hoisted_smi_check_test.dart View 1 1 chunk +0 lines, -19 lines 0 comments Download
A + tests/language/deopt_hoisted_smi_check_vm_test.dart View 1 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
7 years, 9 months ago (2013-03-13 18:05:54 UTC) #1
Florian Schneider
LGTM.
7 years, 9 months ago (2013-03-13 18:09:19 UTC) #2
Vyacheslav Egorov (Google)
7 years, 9 months ago (2013-03-13 18:28:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698