Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 12690003: Revert "Don't output tons of messages on apidoc." and "Fix bot breaks." (Closed)

Created:
7 years, 9 months ago by ahe
Modified:
7 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Andrei Mouravski, sra1, dgrove, bakster, kasperl
Visibility:
Public.

Description

Revert "Don't output tons of messages on apidoc." and "Fix bot breaks." This reverts r19662 and r19666. Committed: https://code.google.com/p/dart/source/detail?r=19694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M dart/pkg/webdriver/lib/webdriver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/library_loader.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart View 2 chunks +1 line, -1 line 0 comments Download
M dart/tests/utils/recursive_import_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
I'm reverting CL 12642004 and CL 12662002. The changes are incorrect. Changing a diagnostic from ...
7 years, 9 months ago (2013-03-08 12:41:11 UTC) #1
Johnni Winther
lgtm
7 years, 9 months ago (2013-03-08 12:45:13 UTC) #2
ahe
7 years, 9 months ago (2013-03-08 13:55:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19694 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698