Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 12690002: - Add simarm and simmips to --arch=all for builds and tests. (Closed)

Created:
7 years, 9 months ago by Ivan Posva
Modified:
7 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, srdjan, regis, Kevin Millikin (Google), Vyacheslav Egorov (Google), Florian Schneider
Visibility:
Public.

Description

- Add simarm and simmips to --arch=all for builds and tests. Committed: https://code.google.com/p/dart/source/detail?r=19684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/build.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
This will make breaking the simarm and simmips backends a lot harder. -Ivan
7 years, 9 months ago (2013-03-08 09:55:37 UTC) #1
ricow1
LGTM
7 years, 9 months ago (2013-03-08 11:46:05 UTC) #2
Ivan Posva
7 years, 9 months ago (2013-03-08 11:47:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698