Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 126883003: Revert "Fix dart2js type warnings" (Closed)

Created:
6 years, 11 months ago by vsm
Modified:
6 years, 11 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Fix dart2js type warnings" This is breaking the Dartium build. Will investigate and hopefully resubmit. TBR=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=31588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -271 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +2 lines, -55 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 10 chunks +5 lines, -119 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/dom/dom.json View 17 chunks +0 lines, -63 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vsm
6 years, 11 months ago (2014-01-07 23:13:35 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r31588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698