Issue 126873003: Revert "Revert "Fix dart2js type warnings""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126873003: Revert "Revert "Fix dart2js type warnings"" (Closed)

Created:
6 years, 11 months ago by vsm

Modified:
6 years, 11 months ago

Reviewers:
Johnni Winther, ahe, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Fix dart2js type warnings"" Retrying with a fix. Patch 1 is initial change. BUG=15954 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=31699

Patch Set 1 #

Patch Set 2 : Don't duplicate ops that are inherited twice. #

Patch Set 3 : Fix typo #

Patch Set 4 : Remove this bug from the whitelist #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+279 lines, -13 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		6 chunks	+55 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		10 chunks	+119 lines, -5 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_api_test.dart	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/dom/dom.json	View		17 chunks	+63 lines, -0 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #4 manually as r31699 (presubmit successful).

6 years, 11 months ago (2014-01-10 19:00:13 UTC) #3

zra

6 years, 11 months ago (2014-01-10 21:14:00 UTC) #4

Message was sent while issue was closed.

On 2014/01/10 19:00:13, vsm wrote:
> Committed patchset #4 manually as r31699 (presubmit successful).

Please also keep an eye on the Dartium+Clank build for this change.

Expand Messages | Collapse Messages