- Implement loading of .packages files from http.

- Implement loading of .packages files from http.
- Fix bad type annotation in builtin.dart when getting an async
  load error.

Committed: https://github.com/dart-lang/sdk/commit/337931709a07e0bf3702d1d4b5239307ee98e40d

[Ivan Posva, 2015-08-05 07:07:42]

iposva@google.com changed reviewers:
+ johnmccutchan@google.com

[Ivan Posva, 2015-08-05 07:07:43]

TBR

[Ivan Posva, 2015-08-05 07:13:44]

Committed patchset #1 (id:1) manually as
337931709a07e0bf3702d1d4b5239307ee98e40d (presubmit successful).

[Cutch, 2015-08-05 14:52:37]

Follow up comments

https://codereview.chromium.org/1268313002/diff/1/runtime/bin/vmservice/loade...
File runtime/bin/vmservice/loader.dart (right):

https://codereview.chromium.org/1268313002/diff/1/runtime/bin/vmservice/loade...
runtime/bin/vmservice/loader.dart:360: if (rsp.statusCode != 200) {
Check status code before awaiting on the payload?

https://codereview.chromium.org/1268313002/diff/1/runtime/bin/vmservice/loade...
runtime/bin/vmservice/loader.dart:400: sp.send("Unsupported base URI to identify
.packages file: "
Unsupported URI scheme?

[Ivan Posva, 2015-08-05 23:58:11]

Thanks! -ip

https://codereview.chromium.org/1268313002/diff/1/runtime/bin/vmservice/loade...
File runtime/bin/vmservice/loader.dart (right):

https://codereview.chromium.org/1268313002/diff/1/runtime/bin/vmservice/loade...
runtime/bin/vmservice/loader.dart:360: if (rsp.statusCode != 200) {
On 2015/08/05 14:52:37, Cutch wrote:
> Check status code before awaiting on the payload?

This follows the non-async/await code above.

https://codereview.chromium.org/1268313002/diff/1/runtime/bin/vmservice/loade...
runtime/bin/vmservice/loader.dart:400: sp.send("Unsupported base URI to identify
.packages file: "
On 2015/08/05 14:52:37, Cutch wrote:
> Unsupported URI scheme?

Done.