Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Issue 126793003: Fix dart2js type warnings (Closed)

Created:
6 years, 11 months ago by vsm
Modified:
6 years, 11 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -7 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +55 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 10 chunks +119 lines, -5 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 17 chunks +63 lines, -0 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
6 years, 11 months ago (2014-01-07 22:35:29 UTC) #1
blois
lgtm- these had to be made public since they are overridden across different libs.
6 years, 11 months ago (2014-01-07 22:48:46 UTC) #2
vsm
6 years, 11 months ago (2014-01-07 22:49:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698