Issue 12678014: Rename RtcdtmfSender class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12678014: Rename RtcdtmfSender class. (Closed)

Created:
7 years, 9 months ago by Emily Fortuna

Modified:
7 years, 9 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename RtcdtmfSender class. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20298

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -151 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+63 lines, -63 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		3 chunks	+88 lines, -88 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm But should get the other item as well. https://codereview.chromium.org/12678014/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/12678014/diff/1/tools/dom/scripts/htmlrenamer.py#newcode37 tools/dom/scripts/htmlrenamer.py:37: ...

7 years, 9 months ago (2013-03-20 22:43:35 UTC) #2

Emily Fortuna

7 years, 9 months ago (2013-03-20 22:51:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20298 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12678014: Rename RtcdtmfSender class. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages