Issue 12678011: Miscellaneous small improvements for scheduled_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12678011: Miscellaneous small improvements for scheduled_test. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Miscellaneous small improvements for scheduled_test. Committed: https://code.google.com/p/dart/source/detail?r=20240

Patch Set 2 : Miscellaneous additional fixes. #

Total comments: 1

Patch Set 3 : Guard against issue 9151 more thoroughly. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -30 lines)			Patch
M	pkg/scheduled_test/lib/scheduled_process.dart	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/schedule_error.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/utils.dart	View		1 chunk	+11 lines, -13 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_server_test.dart	View	1 2	6 chunks	+55 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/12678011/diff/3001/pkg/scheduled_test/lib/src/schedule_error.dart File pkg/scheduled_test/lib/src/schedule_error.dart (right): https://codereview.chromium.org/12678011/diff/3001/pkg/scheduled_test/lib/src/schedule_error.dart#newcode57 pkg/scheduled_test/lib/src/schedule_error.dart:57: } Nice!

7 years, 9 months ago (2013-03-19 16:18:21 UTC) #2

nweiz

7 years, 9 months ago (2013-03-19 20:53:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r20240 (presubmit successful).