Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1267633003: Don't force msvs 2010 version when running gyp (Closed)

Created:
5 years, 4 months ago by ricow1
Modified:
5 years, 4 months ago
Reviewers:
ahe, Bill Hesse, Ivan Posva
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/gyp_dart.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
5 years, 4 months ago (2015-07-30 14:05:05 UTC) #1
ricow1
TBR
5 years, 4 months ago (2015-07-30 14:08:46 UTC) #2
ahe
lgtm
5 years, 4 months ago (2015-07-30 14:09:15 UTC) #3
ricow1
5 years, 4 months ago (2015-07-30 14:09:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b67b36ab2ab0f63402a5925b7d475e461167edf7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698