Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1267603003: Support sending and receiving Capability objects from C code. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support sending and receiving Capability objects from C code. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/53dbc3764da823e247279ab5d8cf0e3fc0a78d09

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M runtime/include/dart_native_api.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 chunks +35 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 4 months ago (2015-07-30 19:19:07 UTC) #2
siva
LGTM with one comment. https://codereview.chromium.org/1267603003/diff/20001/runtime/vm/snapshot_test.cc File runtime/vm/snapshot_test.cc (right): https://codereview.chromium.org/1267603003/diff/20001/runtime/vm/snapshot_test.cc#newcode436 runtime/vm/snapshot_test.cc:436: CheckEncodeDecodeMessage(root); You should probably also ...
5 years, 4 months ago (2015-07-30 19:44:07 UTC) #3
turnidge
https://codereview.chromium.org/1267603003/diff/20001/runtime/vm/snapshot_test.cc File runtime/vm/snapshot_test.cc (right): https://codereview.chromium.org/1267603003/diff/20001/runtime/vm/snapshot_test.cc#newcode436 runtime/vm/snapshot_test.cc:436: CheckEncodeDecodeMessage(root); On 2015/07/30 19:44:06, siva wrote: > You should ...
5 years, 4 months ago (2015-07-30 21:04:13 UTC) #4
turnidge
5 years, 4 months ago (2015-07-30 21:07:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
53dbc3764da823e247279ab5d8cf0e3fc0a78d09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698