Collapse successful GET messages together.

Collapse successful GET messages together.

Makes pub serve less spammy when used with Dartium where you have a
slew of requests for each source file.

Committed: https://github.com/dart-lang/pub/commit/11daef3f1b422e369f33a8ec5a3281206845364c

[Bob Nystrom, 2015-07-31 21:27:21]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2015-07-31 22:42:35]

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart
File lib/src/log.dart (right):

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart#newcode432
lib/src/log.dart:432: void collapsible(String message) {
Rather than only printing this once the timeout has elapsed, why not print it
immediately and use \r to dynamically update the hidden message count (at least
on non-Windows OSes)?

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart#newcode443
lib/src/log.dart:443: _collapsibleTimer = new Timer(new Duration(milliseconds:
100),
Consider making this duration a top-level constant.

[Bob Nystrom, 2015-08-03 21:51:02]

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart
File lib/src/log.dart (right):

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart#newcode432
lib/src/log.dart:432: void collapsible(String message) {
On 2015/07/31 22:42:35, nweiz wrote:
> Rather than only printing this once the timeout has elapsed, why not print it
> immediately and use \r to dynamically update the hidden message count (at
least
> on non-Windows OSes)?

I thought about that, but the output lines can be unexpectedly long and "\r"
gets super flaky in that case. I figured this would be simpler and more
reliable.

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart#newcode443
lib/src/log.dart:443: _collapsibleTimer = new Timer(new Duration(milliseconds:
100),
On 2015/07/31 22:42:35, nweiz wrote:
> Consider making this duration a top-level constant.

Done.

[nweiz, 2015-08-03 22:11:11]

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart
File lib/src/log.dart (right):

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart#newcode432
lib/src/log.dart:432: void collapsible(String message) {
On 2015/08/03 21:51:02, Bob Nystrom wrote:
> On 2015/07/31 22:42:35, nweiz wrote:
> > Rather than only printing this once the timeout has elapsed, why not print
it
> > immediately and use \r to dynamically update the hidden message count (at
> least
> > on non-Windows OSes)?
> 
> I thought about that, but the output lines can be unexpectedly long and "\r"
> gets super flaky in that case. I figured this would be simpler and more
> reliable.

Since this is pub, we should be able to safely use Stdout.terminalColumns to
check if that's possible. I'd really like to avoid just printing *no output* for
a long period of time.

[Bob Nystrom, 2015-08-05 21:25:39]

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart
File lib/src/log.dart (right):

https://codereview.chromium.org/1267023002/diff/1/lib/src/log.dart#newcode432
lib/src/log.dart:432: void collapsible(String message) {
On 2015/08/03 22:11:10, nweiz wrote:
> On 2015/08/03 21:51:02, Bob Nystrom wrote:
> > On 2015/07/31 22:42:35, nweiz wrote:
> > > Rather than only printing this once the timeout has elapsed, why not print
> it
> > > immediately and use \r to dynamically update the hidden message count (at
> > least
> > > on non-Windows OSes)?
> > 
> > I thought about that, but the output lines can be unexpectedly long and "\r"
> > gets super flaky in that case. I figured this would be simpler and more
> > reliable.
> 
> Since this is pub, we should be able to safely use Stdout.terminalColumns to
> check if that's possible. I'd really like to avoid just printing *no output*
for
> a long period of time.

Tried a different approach based on our discussion.

[nweiz, 2015-08-05 22:57:14]

https://codereview.chromium.org/1267023002/diff/40001/lib/src/log.dart
File lib/src/log.dart (right):

https://codereview.chromium.org/1267023002/diff/40001/lib/src/log.dart#newcod...
lib/src/log.dart:624: message(_template.replaceAll("##", _count.toString()));
I'd still really like to have this dynamically update with "\r" on OSes that
support it, especially since the template is now small enough to ensure that
this won't break.

[Bob Nystrom, 2015-08-05 23:49:23]

https://codereview.chromium.org/1267023002/diff/40001/lib/src/log.dart
File lib/src/log.dart (right):

https://codereview.chromium.org/1267023002/diff/40001/lib/src/log.dart#newcod...
lib/src/log.dart:624: message(_template.replaceAll("##", _count.toString()));
On 2015/08/05 22:57:14, nweiz wrote:
> I'd still really like to have this dynamically update with "\r" on OSes that
> support it, especially since the template is now small enough to ensure that
> this won't break.

Leaving as-is per our discussion.

[Bob Nystrom, 2015-08-05 23:50:04]

Committed patchset #3 (id:40001) manually as
11daef3f1b422e369f33a8ec5a3281206845364c (presubmit successful).