Issue 12670017: Incorporate Pete's comments on KeyboardEventStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12670017: Incorporate Pete's comments on KeyboardEventStream. (Closed)

Created:
7 years, 8 months ago by Emily Fortuna

Modified:
7 years, 8 months ago

Reviewers:
Andrei Mouravski, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Incorporate Pete's comments on KeyboardEventStream. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20551

Patch Set 1 : #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -35 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	4 chunks	+35 lines, -9 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+35 lines, -9 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/html/interactive_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/html/keyboard_event_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/KeyboardEventStream.dart	View	4 chunks	+35 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Incorporates Pete's suggestion about the static variable and returning a new KeyboardEventHandler object instead, and ...

7 years, 8 months ago (2013-03-26 21:59:43 UTC) #1

Andrei Mouravski

lgtm https://codereview.chromium.org/12670017/diff/2001/tools/dom/src/KeyboardEventStream.dart File tools/dom/src/KeyboardEventStream.dart (right): https://codereview.chromium.org/12670017/diff/2001/tools/dom/src/KeyboardEventStream.dart#newcode77 tools/dom/src/KeyboardEventStream.dart:77: var newController = new _KeyboardEventHandler.initializeAllEventListeners( I'd inline this.

7 years, 8 months ago (2013-03-27 00:03:35 UTC) #2

Emily Fortuna

7 years, 8 months ago (2013-03-27 00:27:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20551 (presubmit successful).

Expand Messages | Collapse Messages