Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 126693002: Fix unknown type error in html_*.dart (Closed)

Created:
6 years, 11 months ago by vsm
Modified:
6 years, 11 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix unknown type error in html_*.dart The type Matrix is used unqualified in html_*.dart (CanvasRenderingContext2D.currentTransform). This imports that type only unqualified. Is there a better way to do this? R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=31585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
6 years, 11 months ago (2014-01-07 22:03:30 UTC) #1
blois
lgtm Can't think of a better way, alternative would be to edit it by hand ...
6 years, 11 months ago (2014-01-07 22:05:55 UTC) #2
vsm
6 years, 11 months ago (2014-01-07 22:11:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698