Issue 1266903004: dart2js: Default values for static functions are now inside closures. (in the startup emitter).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1266903004: dart2js: Default values for static functions are now inside closures. (in the startup emitter). (Closed)

Created:
5 years, 4 months ago by floitsch

Modified:
5 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Default values for static functions are now inside closures. (in the startup emitter). Since static closures are const values, they can reference each other in the default values: foo([x = bar]) => null; bar([x = foo]) => null; Therefore, we must not reference the default values during tear-off installation (as was the case until now). The corresponding test has been uploaded in https://chromiumcodereview.appspot.com/1255083008/ R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e9b91c7c929b44c94b80a3e84de010f1dd9f466f

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart	View		3 chunks	+5 lines, -4 lines	0 comments	Download
	M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View		1 chunk	+9 lines, -7 lines	0 comments	Download

Total messages: 5 (1 generated)

floitsch

5 years, 4 months ago (2015-08-04 11:56:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e9b91c7c929b44c94b80a3e84de010f1dd9f466f (presubmit successful).