Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 126683002: Fix for Issue 15911, use IsInlinable() to determine if TryInlineRecognizedMethod needs to be called… (Closed)

Created:
6 years, 11 months ago by siva
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix for Issue 15911, use IsInlinable() to determine if TryInlineRecognizedMethod needs to be called. Set is_inlinable to false when a function is marked as not optimizable. R=fschneider@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31616

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/flow_graph_inliner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
6 years, 11 months ago (2014-01-08 00:14:27 UTC) #1
Florian Schneider
lgtm
6 years, 11 months ago (2014-01-08 10:08:18 UTC) #2
srdjan
lgtm
6 years, 11 months ago (2014-01-08 17:47:29 UTC) #3
siva
6 years, 11 months ago (2014-01-08 17:49:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r31616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698