Issue 12667016: Use default-port-aware URI comparisons in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12667016: Use default-port-aware URI comparisons in pub. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use default-port-aware URI comparisons in pub. This fixes a usability issue where error messages from pub.dartlang.org were getting reported as generic HTTP errors. Committed: https://code.google.com/p/dart/source/detail?r=19826

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	utils/pub/command_lish.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	utils/pub/http.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	utils/pub/utils.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

LGTM https://codereview.chromium.org/12667016/diff/1/utils/pub/command_lish.dart File utils/pub/command_lish.dart (right): https://codereview.chromium.org/12667016/diff/1/utils/pub/command_lish.dart#newcode89 utils/pub/command_lish.dart:89: // TODO(nweiz): the response may have XML-formatted information ...

7 years, 9 months ago (2013-03-11 22:58:54 UTC) #2

nweiz

https://codereview.chromium.org/12667016/diff/1/utils/pub/command_lish.dart File utils/pub/command_lish.dart (right): https://codereview.chromium.org/12667016/diff/1/utils/pub/command_lish.dart#newcode89 utils/pub/command_lish.dart:89: // TODO(nweiz): the response may have XML-formatted information about ...

7 years, 9 months ago (2013-03-11 22:59:37 UTC) #3

nweiz

7 years, 9 months ago (2013-03-11 23:07:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19826 (presubmit successful).

Expand Messages | Collapse Messages