Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1266603005: Add a CancelableFuture class. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a CancelableFuture class. This is useful for controlling processes that the user may want a value out of or may want to cancel. R=lrn@google.com Committed: https://github.com/dart-lang/async/commit/ed025a1ca8f581c96d675a273ce476cb6a186556

Patch Set 1 #

Patch Set 2 : Convert to CancelableOperation #

Total comments: 34

Patch Set 3 : Code review changes #

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -0 lines) Patch
M lib/async.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A lib/src/cancelable_operation.dart View 1 2 3 1 chunk +148 lines, -0 lines 0 comments Download
A test/cancelable_operation_test.dart View 1 1 chunk +197 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
nweiz
5 years, 4 months ago (2015-07-29 19:39:08 UTC) #2
Lasse Reichstein Nielsen
As a general principle,. I don't think a "cancelable future" is a good idea. It ...
5 years, 4 months ago (2015-08-03 08:15:33 UTC) #3
Lasse Reichstein Nielsen
After a little more thought, a Computation class could look like: /// A cancelable computation. ...
5 years, 4 months ago (2015-08-03 08:44:14 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode11 lib/src/cancelable_operation.dart:11: /// An asynchronuos operation that can be cancelled. So ...
5 years, 3 months ago (2015-08-27 10:20:54 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode27 lib/src/cancelable_operation.dart:27: CancelableOperation._(this._completer); I think one thing that makes it hard ...
5 years, 3 months ago (2015-08-27 10:57:41 UTC) #6
Lasse Reichstein Nielsen
https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode27 lib/src/cancelable_operation.dart:27: CancelableOperation._(this._completer); On 2015/08/27 10:57:41, Lasse Reichstein Nielsen wrote: > ...
5 years, 3 months ago (2015-08-27 10:59:47 UTC) #7
nweiz
Code review changes
5 years, 3 months ago (2015-08-28 00:33:08 UTC) #8
nweiz
https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode11 lib/src/cancelable_operation.dart:11: /// An asynchronuos operation that can be cancelled. On ...
5 years, 3 months ago (2015-08-28 00:34:56 UTC) #9
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode22 lib/src/cancelable_operation.dart:22: Future<T> get value => _completer._inner.future; The order in ...
5 years, 3 months ago (2015-09-03 13:06:18 UTC) #10
nweiz
https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode38 lib/src/cancelable_operation.dart:38: return completer.operation; On 2015/09/03 13:06:17, Lasse Reichstein Nielsen wrote: ...
5 years, 3 months ago (2015-09-08 21:14:45 UTC) #11
nweiz
https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart File lib/src/cancelable_operation.dart (right): https://codereview.chromium.org/1266603005/diff/20001/lib/src/cancelable_operation.dart#newcode38 lib/src/cancelable_operation.dart:38: return completer.operation; On 2015/09/03 13:06:17, Lasse Reichstein Nielsen wrote: ...
5 years, 3 months ago (2015-09-08 21:14:45 UTC) #12
nweiz
Code review changes
5 years, 3 months ago (2015-09-08 21:15:07 UTC) #13
nweiz
5 years, 3 months ago (2015-09-08 21:15:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
ed025a1ca8f581c96d675a273ce476cb6a186556 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698